-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes of #1441 #1444
Revert changes of #1441 #1444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about updating the documentation to suggest this possible solution? So other devs can add this class (the old one I mean) and exploit this implementation.
@garak it's a good idea. I can add this information to the documentation for people who will want this feature. With custom storage, it will be simple to implement. Let me try to explain it. Edit: Done, let me know if it is not ok or not clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, yesterday I was in a hurry and didn't notice the invalid markdown. Could you fix it please?
@garak was it related to the last link that I added? If yes, I fixed it, and used a markdown validator to be sure that it is valid. |
As you can see in the related Action, we enforce a custom rule about the maximum length of the lines. |
FlysystemStorage is final, you cannot extend it. |
Yes, maybe my wording is not correct, but I was meaning that we have to duplicate its code |
@sovetski still waiting for a fix in the markdown |
@garak sorry for the delay, it looks OK now |
It looks like it is a breaking change, as mentionned by 3 people here: #1441
Maybe in the future it will be implemented in a major release (I hope)